Space bodies deferred addition #5648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps that iterate through them The undefined behaviour comes because when we add an item to the vector, it could have to reallocate to grow the backing storage and therefore the end iterator becomes potentially invalid. Defer adding bodies until the end of an Space update tick. A few game related scenarios (emerging from hyperspace, saving a game and loading a game) require this update to be invoked too.
JonBooth78
force-pushed
the
space-bodies-deferred-addition
branch
from
c55f205 to
10d878a
Compare
|
Hey, I'd almost forgotten about this one! Good work, the code looks clean and I'll give it a quick spin but I don't anticipate any problems. |
sturnclaw
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the undefined behaviour when addiing bodies during the update loops that iterate through them
The undefined behaviour comes because when we add an item to the vector, it could have to reallocate to grow the backing storage and therefore the end iterator becomes potentially invalid.
Defer adding bodies until the end of an Space update tick.
A few game related scenarios (emerging from hyperspace, saving a game and loading a game) require this update to be invoked too.
I've been playing with this locally for a while and have yet to find any new issues.