Skip to content

Commit

Permalink
refactor: clean up Player::OnEnterSystem
Browse files Browse the repository at this point in the history
The call to ResetHyperspaceTarget in Player::OnEnterSystem has been
superfluous since probably commit
1e2e471.

As there was a comment that the SectorView should not be invoked from
this callback, and recent testing showed that it did not impact the game
logic, lets remove it and resolve the comment.
  • Loading branch information
mwerle committed Oct 7, 2024
1 parent 5e7d486 commit 7c5a654
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/Player.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,6 @@ void Player::OnEnterHyperspace()
void Player::OnEnterSystem()
{
m_controller->SetFlightControlState(CONTROL_MANUAL);
//XXX don't call sectorview from here, use signals instead
Pi::game->GetSectorView()->ResetHyperspaceTarget();
}

//temporary targeting stuff
Expand Down

0 comments on commit 7c5a654

Please sign in to comment.