Split API compatibility check job #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at-wat
force-pushed
the
split-api-compatibility-check-job
branch
from
27fd90d
to
a362e53
Compare
at-wat
added a commit
to pion/ci-sandbox
that referenced
this pull request
Feb 29, 2024
at-wat
added a commit
to pion/ci-sandbox
that referenced
this pull request
Feb 29, 2024
Make it possible to distinguish whether the unit tests are failing or just pointing out API breakage from CI status.
at-wat
force-pushed
the
split-api-compatibility-check-job
branch
from
a362e53
to
9def2f6
Compare
at-wat
added a commit
to pion/ci-sandbox
that referenced
this pull request
Feb 29, 2024
|
@Sean-Der please take a look |
Sean-Der
approved these changes
Mar 4, 2024
|
LGTM! Sorry I didn't do that before. When this rolls out I will go through repos and make sure this is a blocking merge requirement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes #197
Example
pion/ci-sandbox#117
Without API breakage
With API breakage