Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golangci-lint to v1.56.2 and always install go #196

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Update golangci-lint to v1.56.2 and always install go #196

merged 2 commits into from
Feb 28, 2024

Conversation

Sean-Der
Copy link
Member

@Sean-Der Sean-Der commented Feb 28, 2024 •
edited by edaniels
Loading

Current version is not Go 1.22 compatible and underlying ubuntu image started using 1.22

@Sean-Der
Update golangci-lint to v1.56.2
154918c 
Current version is not Go 1.22 compatiable
@edaniels edaniels changed the title Update golangci-lint to v1.56.2 Update golangci-lint to v1.56.2 and always install go Feb 28, 2024
@edaniels edaniels merged commit 5df7184 into master Feb 28, 2024
4 checks passed
@edaniels edaniels deleted the update-golangci-lint branch February 28, 2024 15:58
@at-wat
Copy link
Member

at-wat commented Feb 29, 2024 •
edited
Loading

Seems introduced a lot of new lint errors:
https://github.com/pion/webrtc/actions/runs/8089732277/job/22106111066?pr=2685#step:5:25

  Running [/home/runner/golangci-lint-1.56.2-linux-amd64/golangci-lint run --out-format=github-actions $GOLANGCI_LINT_EXRA_ARGS] in [] ...
  Warning: unused-parameter: parameter 'headPacket' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'o' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'receiver' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'receiver' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'w' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'w' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'w' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'receiver' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'id' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'track' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'track' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'track' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'd' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'attributes' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'pair' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'cs' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'd' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'ss' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'pcs' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'ics' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'trackRemote' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'i' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'i' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'i' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'midValue' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'm' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'p' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'msg' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'd' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'msg' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'msg' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
  
  Error: issues found
  Ran golangci-lint in 33923ms

This was referenced Feb 29, 2024
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edaniels edaniels edaniels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sean-Der @at-wat @edaniels