Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code editor tab behavior #1520

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Fix code editor tab behavior #1520

merged 2 commits into from
Nov 21, 2024

Conversation

czgu
Copy link
Collaborator

@czgu czgu commented Nov 20, 2024 •
edited
Loading

  • removed indentWithTab and use insertTab instead
  • removed indentWithTab in uiw/codemirror
  • moved tab keymap to keymap extension instead since it doesn't tie with the tab editor option
  • Updated theme to make gutter more visible
  • Fixed issue with indent service at pos 0.
    image
    image

@czgu czgu requested a review from jczhong84 November 20, 2024 22:48
@czgu czgu merged commit 7dd47c0 into pinterest:master Nov 21, 2024
5 checks passed
@czgu czgu deleted the tabfix branch November 21, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangvi7 zhangvi7 zhangvi7 approved these changes

@jczhong84 jczhong84 Awaiting requested review from jczhong84

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czgu @zhangvi7