feat: Add top-tier icons #1483
Merged
feat: Add top-tier icons #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baumandm
force-pushed
the
external/top-tier
branch
from
5aac462
to
e4d8094
Compare
czgu
reviewed
Aug 13, 2024
querybook/webapp/components/DataTableNavigator/DataTableNavigator.tsx
Outdated
Show resolved
Hide resolved
czgu
reviewed
Aug 13, 2024
| }> = ({ showTooltip = false, tooltipPos = 'down' }) => { | ||
| if (showTooltip) { | ||
| return ( | ||
| <span |
There was a problem hiding this comment.
can we always return a span, but let props passed to be dynamic?
| aria-label="Top Tier" | ||
| data-balloon-pos={tooltipPos} | ||
| > | ||
| <Icon className="ml4" name="Crown" /> |
There was a problem hiding this comment.
also i think its better to just pass a className, since hard coding ml4 would be depending on the outer context?
| @@ -0,0 +1,23 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
can you put this component in ui/TopTierCrown instead?
czgu
reviewed
Aug 13, 2024
| @@ -23,6 +23,8 @@ import { Title } from 'ui/Title/Title'; | |||
| import { ToggleSwitch } from 'ui/ToggleSwitch/ToggleSwitch'; | |||
|
|
|||
| import './DataTableNavigatorSearch.scss'; | |||
| import { Icon } from 'ui/Icon/Icon'; | |||
czgu
approved these changes
Nov 4, 2024
czgu
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the top tier crown icon in additional places to help with visibility for users:
The component applies consistent styling everywhere, and optionally includes a tool tip (not used where obvious, like in the filter list next to a label)
The crown has been added in the following spots:
Top Tiertag/buttonOther places where the crown already existed have been updated to use a shared component, which provides consistent styling.