feat: pass api_access_token to executor client #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
czgu
reviewed
Jul 4, 2024
querybook/server/app/auth/utils.py
Outdated
| @@ -19,8 +19,13 @@ class AuthenticationError(Exception): | |||
|
|
|||
|
|
|||
| class AuthUser(UserMixin): | |||
| def __init__(self, user: User): | |||
| def __init__(self, user: User, api_access_token=False): | |||
There was a problem hiding this comment.
api_access_token is a boolean flag?
There was a problem hiding this comment.
consider renaming it to something more clear
Comment on lines
75
to
82
| api_access_token = ( | ||
| True if request.headers.get("api-access-token", None) else False | ||
| ) | ||
| metadata = metadata or {} | ||
| metadata["api_access_token"] = api_access_token | ||
| logic.create_query_execution_metadata( | ||
| query_execution.id, metadata, session=session | ||
| ) |
There was a problem hiding this comment.
metadata = {}
used_api_token = request.headers.get("api-access-token", None) is not None
if used_api_token:
metadata["used_api_token"] = used_api_token
if metadata:
logic.create(...)
| @@ -528,6 +528,16 @@ def __init__( | |||
| self._client = None | |||
| self._cursor = None | |||
|
|
|||
| with DBSession() as session: | |||
There was a problem hiding this comment.
dbsession is not needed if you are only calling once
| @@ -528,6 +528,16 @@ def __init__( | |||
| self._client = None | |||
| self._cursor = None | |||
|
|
|||
| with DBSession() as session: | |||
| query_execution_metadata = ( | |||
There was a problem hiding this comment.
this might be None? (if metadata wasn't created)
| self._query_execution_id, session=session | ||
| ).execution_metadata | ||
| ) | ||
| self._api_access_token = query_execution_metadata.get( |
There was a problem hiding this comment.
rename to used_api_token or some other boolean name
api_access_token was used as a str to represent the actual token, let's not reuse the same name for a boolean flag?
czgu
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use
api-access-tokenin request header, then pass it down to the executor clientThen in Presto client, we can use this flag to determine whether to continue using ldap auth or pass outh jwt instead.