Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth0 Integration V2 #1392

Merged
merged 4 commits into from
Apr 6, 2024
Merged

Conversation

aidenprice
Copy link
Contributor

Hi again,

This is the cleaned up PR from the previous attempt, please ignore my earlier PR and consider this one instead. Sorry for the messy git history.

This PR adds Auth0 OAuth integration following the same pattern as Okta. The key names are different enough to justify a different handler.

Thank you again,
Aiden

@jczhong84
Copy link
Collaborator

jczhong84 commented Feb 25, 2024

@aidenprice thanks for the PR to add Auth0.
Looks like it's mostly same as okta except the get_auth0_urls. Maybe we can just inherit it from OktaLoginManager, rename get_okta_urls as get_oauth_urls and override it for Auth0LoginManager

btw as I know, auth0 and okta are the same company now.

@aidenprice
Copy link
Contributor Author

Hi, I've tried your suggestion and it certainly cleans up a lot of repeated code.
One thing I should point out though, the LOG = get_logger(__file__) isn't inheritable or injectable. So when you instantiate an Auth0LoginManager it will represent logs as coming from the Okta file.

Unused code
@jczhong84 jczhong84 merged commit 7fa6eb6 into pinterest:master Apr 6, 2024
4 checks passed
@aidenprice
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants