fix: init_es.py script not completing due to AttributeError #1309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small bug in the
querybook.server.logic.elasticsearch._bulk_insert_users()
function. Theget_users_iter
function used to return adict
object representation of the users in the database, but the_bulk_insert_users
function tries to access theis_group
attribute found in theUser
SQLAlchemy model.Running this function with users already present in the database (usually through the
init_es.py
script invoked by--initdb
) results in the following error:The proposed fix is to return
User
instances from theget_users_iter
function and then convert them to ElasticSearch compatibledict
objects in the functions that need it (_bulk_insert_users()
and_bulk_update_users(fields: Set[str] = None)
).