I18N-1318 - Add 'Introduced By' field to show the source URL that created a text unit #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwilshire
requested review from
maallen,
byronantak,
DarKhaos and
garionpin
byronantak
reviewed
Nov 12, 2024
webapp/src/main/resources/db/migration/V71__Add_branch_source.sql
Outdated
Show resolved
Hide resolved
webapp/src/main/resources/db/migration/V71__Add_branch_source.sql
Outdated
Show resolved
Hide resolved
byronantak
approved these changes
Nov 13, 2024
maallen
reviewed
Nov 18, 2024
webapp/src/main/java/com/box/l10n/mojito/service/branch/BranchService.java
Outdated
Show resolved
Hide resolved
maallen
approved these changes
Nov 19, 2024
mattwilshire
force-pushed
the
mattwilshire/textunit-introduced-link
branch
from
2d3d6f0
to
3bd3fe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a table "tm_text_unit_to_branch" to map a text unit to its branch. (Text units will map to a null branch / master if they are pushed again and newly pushed text units map to a branch that has no name if the TU wasn't added from a extraction-diff) To make things clearer, this table will store the branch that created the text unit from now on.
Added a table "branch_source" to store information about the source of the branch creation (url for now). For example, if your branch name in Mojito corresponds to a branch in a Github repository you can have the following in your application.properties to create source URLs for each new branch under the repository "REPONAME":
l10n.branchSources.REPONAME.url=https://github.com/{branchName}