Added config value to enable/disable Quartz scheduler on a server #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompose cluster to test API & worker nodes config
aurambaj
reviewed
Aug 15, 2023
webapp/src/main/java/com/box/l10n/mojito/quartz/QuartzConfig.java
Outdated
Show resolved
Hide resolved
|
Nice! It will be very handy to have this docker-compose setup for testing. |
…replicas for api & worker nodes
garionpin
approved these changes
Aug 16, 2023
aurambaj
reviewed
Aug 16, 2023
| /** | ||
| * Starts the scheduler after having removed outdated trigger/jobs | ||
| * | ||
| * @throws SchedulerException | ||
| */ | ||
| @PostConstruct | ||
| void startScheduler() throws SchedulerException { | ||
| Properties quartzProps = quartzPropertiesConfig.getQuartzProperties(); |
There was a problem hiding this comment.
For now, this will do but I find it weird to have to inject/read the properties here again vs. being able to read information on the scheduler instance itself. With the multi scheduler implementation we may have a new Scheduler class that could include a field like "shouldStart". And this QuartzConfig may be totally different anyway as the job detail and outdated jobs will probably be per scheduler instances.
aurambaj
approved these changes
Aug 16, 2023
aurambaj
pushed a commit
that referenced
this pull request
Sep 2, 2023
* Added config value to enable/disable Quartz scheduler. added docker compose cluster to test API & worker nodes config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New configuration value allows the Quartz scheduler to be disabled on a node via an application.properties value. This will be utilised in the cluster separation to distinguish worker nodes and api nodes.
Added docker compose cluster that contains a single mysql DB alongside a mojito-api and mojito-worker service that can be used for testing the multi cluster configuration. Successfully sent a command via mojito-cli to an api node which created a pollable task that was picked up and executed by a worker.
mojito-apiserver handling a demo create request, creating the pollable task for asset extraction which is then handled by themojito-workercontainer