Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove array from the columnInfo and FieldType #320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YangKeao
Copy link
Member

Revert #317.

It's fine to just delete the array field, as both the tikv/tikv#15537 and pingcap/tidb#46718 are not merged, and the array field is not used in tidb and tikv.

I also left a comment to avoid reusing the field id (though it's not a big problem to reuse the id of array, because they are not used in any released version).

@YangKeao YangKeao requested a review from bb7133 September 25, 2023 09:06
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 5, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants