Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine(dm): adjust the subtask config #7651

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

lance6716
Copy link
Contributor

Signed-off-by: lance6716 [email protected]

What problem does this PR solve?

Issue Number: close #4287

What is changed and how it works?

the OP logic is expected that all subtasks are called adjust. So for engine task we also do it

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    service should be able to adjust the value to LoadModelLogical

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 21, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • okJiang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 21, 2022
@lance6716
Copy link
Contributor Author

/cc @okJiang @GMHDBJD

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 21, 2022
@lance6716
Copy link
Contributor Author

/run-engine-integration-test

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2022

Codecov Report

Merging #7651 (03e6901) into master (0438dd4) will decrease coverage by 0.2004%.
The diff coverage is 38.1870%.

Additional details and impacted files
Flag Coverage Δ
cdc 66.3584% <35.8649%> (-0.5583%) ⬇️
dm 52.1129% <41.1764%> (+0.0302%) ⬆️
engine 63.7056% <68.0555%> (-0.0805%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7651        +/-   ##
================================================
- Coverage   60.0458%   59.8454%   -0.2005%     
================================================
  Files           807        810         +3     
  Lines         92391      93018       +627     
================================================
+ Hits          55477      55667       +190     
- Misses        32099      32496       +397     
- Partials       4815       4855        +40     

@okJiang
Copy link
Member

okJiang commented Nov 21, 2022

test still failed @lance6716

@lance6716
Copy link
Contributor Author

lance6716 commented Nov 21, 2022

test still failed @lance6716

it should be a flaky test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 21, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 21, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 03e6901

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 21, 2022
@ti-chi-bot
Copy link
Member

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit ca51860 into pingcap:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refine code
5 participants