dm: fix upstream switch job test #11745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11745 +/- ##
================================================
+ Coverage 55.1510% 55.1984% +0.0474%
================================================
Files 1002 1002
Lines 137399 137598 +199
================================================
+ Hits 75777 75952 +175
- Misses 56074 56102 +28
+ Partials 5548 5544 -4
|
lance6716
approved these changes
Nov 15, 2024
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| set -eu | |||
|
|
|||
| export DM_MASTER_EXTRA_ARG="" | |||
There was a problem hiding this comment.
Will it overwrite the DM_MASTER_EXTRA_ARG set by GitHub secret?
There was a problem hiding this comment.
just same with other test
Line 6 in 68c22f3
ti-chi-bot
bot
added
needs-1-more-lgtm
D3Hunter
approved these changes
Nov 21, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/retest |
5 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4287
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note