-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the problem that /debug/pprof/heap will wait 10s #403
Conversation
Signed-off-by: Calvin Neo <[email protected]>
Co-authored-by: JaySon <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
…into support-purge
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
The problem is that according to
tidb-engine-ext/proxy_components/proxy_server/src/status_server/profile.rs
Line 104 in 50b8d2e
However, if we already enabled prof.active, it is no longer necessary to sleep this duration to sample.
So we will remove this interval, and dump directly. And thus requires the user to explicitly turn on prof.active.
This behavior also correspond to the behavior that after we enabled continous profiling, which TiKV already did.
The change is that we totally use TiKV's idea that make
/heap
dump only theprof.dump
file.What is changed and how it works?
Issue Number: Close #xxx
What's Changed:
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note