Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: add cluster id in batch cmd #1232

Closed
wants to merge 1 commit into from
Closed

kv: add cluster id in batch cmd #1232

wants to merge 1 commit into from

Conversation

cfzjywxk
Copy link
Contributor

Ref: tikv/tikv#16545

Add the cluster_id field in the BatchCommandRequest.

zyguan
zyguan approved these changes Mar 1, 2024
View reviewed changes
Copy link

@zyguan zyguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BTW, do we also check individual requests in batch?

@cfzjywxk
Copy link
Contributor Author

cfzjywxk commented Mar 1, 2024

LGTM

BTW, do we also check individual requests in batch?

I think we just check the batch.

MyonKeminta
MyonKeminta approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@MyonKeminta MyonKeminta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks nice to me to add this and check both, but actually I think it's enough if we do the check in the common path of batched and non-batched single requests.

@cfzjywxk cfzjywxk mentioned this pull request Mar 5, 2024
Merged
1 task
@cfzjywxk cfzjywxk closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyonKeminta MyonKeminta MyonKeminta approved these changes

@zyguan zyguan zyguan approved these changes

@you06 you06 Awaiting requested review from you06

@ekexium ekexium Awaiting requested review from ekexium

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cfzjywxk @zyguan @MyonKeminta