Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: update the fix-control doc #19520

Merged
merged 5 commits into from
Dec 13, 2024
Merged

planner: update the fix-control doc #19520

merged 5 commits into from
Dec 13, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Nov 28, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 28, 2024
winoros
winoros reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fixcontrol#46177 also needs a update

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 29, 2024

@winoros: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Oreoxmt Oreoxmt self-assigned this Dec 13, 2024
@Oreoxmt Oreoxmt added the translation/doing This PR's assignee is translating this PR. label Dec 13, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Dec 13, 2024
@Oreoxmt Oreoxmt self-requested a review December 13, 2024 03:19
@Oreoxmt Oreoxmt added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. labels Dec 13, 2024
Oreoxmt
Oreoxmt reviewed Dec 13, 2024
View reviewed changes
optimizer-fix-controls.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Dec 13, 2024
View reviewed changes
optimizer-fix-controls.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Dec 13, 2024
View reviewed changes
optimizer-fix-controls.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt added requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Dec 13, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 13, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-13 06:06:19.243177155 +0000 UTC m=+591369.331979698: ☑️ agreed by Oreoxmt.

This was referenced Dec 13, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #19674.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 13, 2024
@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#19520
7eea670 
Signed-off-by: ti-chi-bot <[email protected]>
This was referenced Dec 13, 2024
Merged
Merged
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 13, 2024
@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#19520
efdf11e 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19675.

This was referenced Dec 13, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 13, 2024
@qw4990 @Oreoxmt
planner: update the fix-control doc (pingcap#19520)
037c3fd
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 13, 2024
@qw4990 @Oreoxmt
planner: update the fix-control doc (pingcap#19520)
fe04724
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 13, 2024
@qw4990 @Oreoxmt
planner: update the fix-control doc (pingcap#19520)
48308c0
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 13, 2024
@qw4990 @Oreoxmt
planner: update the fix-control doc (pingcap#19520)
2e841dd
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Dec 13, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #19678.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 13, 2024
@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#19520
a756a2d 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 13, 2024
Merged
17 tasks
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 13, 2024
@qw4990 @Oreoxmt
planner: update the fix-control doc (pingcap#19520)
416675d
ti-chi-bot bot pushed a commit that referenced this pull request Dec 13, 2024
@ti-chi-bot
planner: update the fix-control doc (#19520) (#19675)
8827790
ti-chi-bot bot pushed a commit that referenced this pull request Dec 13, 2024
@ti-chi-bot
planner: update the fix-control doc (#19520) (#19673)
8902831
ti-chi-bot bot pushed a commit that referenced this pull request Dec 13, 2024
@ti-chi-bot
planner: update the fix-control doc (#19520) (#19674)
b2cbb0b
ti-chi-bot bot pushed a commit that referenced this pull request Dec 13, 2024
@ti-chi-bot
planner: update the fix-control doc (#19520) (#19670)
2c02b87
ti-chi-bot bot pushed a commit that referenced this pull request Dec 13, 2024
@ti-chi-bot
planner: update the fix-control doc (#19520) (#19678)
8308d67
ti-chi-bot bot pushed a commit that referenced this pull request Dec 13, 2024
@ti-chi-bot
planner: update the fix-control doc (#19520) (#19672)
fee2f74
ti-chi-bot bot pushed a commit that referenced this pull request Dec 13, 2024
@ti-chi-bot
planner: update the fix-control doc (#19520) (#19671)
4400e15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@winoros winoros winoros approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qw4990 @Oreoxmt @ti-chi-bot @winoros