Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud: Polish availability and limitation of Vector Search #19494

Merged
merged 18 commits into from
Nov 28, 2024

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Nov 24, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Close #19373

  • To reduce confusions like Impossible to run standalone or offline autoflow#399, availability is now more precisely described, and some missing pages are also included.

    image
  • Polish the limitation part. The wording is now better choosen:

    • "Currently" means it is a temporary situation and may subject to change in future.
    • Removed all notes about TiFlash deployment, because it is by default in TiDB Serverless
    • Wording is carefully polished, becomes softer in many cases, in order to align with users' real requirements (what users do not care in most cases should not use rigorous words).
    image image image

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 24, 2024
Copy link
Member

@Icemap Icemap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@Icemap
Copy link
Member

Icemap commented Nov 24, 2024

We need to set the spaces for each tab in the same way as other documents.

tidb-cloud/vector-search-data-types.md Outdated Show resolved Hide resolved
tidb-cloud/vector-search-functions-and-operators.md Outdated Show resolved Hide resolved
tidb-cloud/vector-search-get-started-using-python.md Outdated Show resolved Hide resolved
tidb-cloud/vector-search-get-started-using-sql.md Outdated Show resolved Hide resolved
tidb-cloud/vector-search-integrate-with-django-orm.md Outdated Show resolved Hide resolved
tidb-cloud/vector-search-limitations.md Outdated Show resolved Hide resolved
tidb-cloud/vector-search-limitations.md Outdated Show resolved Hide resolved
tidb-cloud/vector-search-limitations.md Outdated Show resolved Hide resolved
tidb-cloud/vector-search-limitations.md Outdated Show resolved Hide resolved
tidb-cloud/vector-search-limitations.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit to qiancai/pingcap-docsite-preview that referenced this pull request Nov 25, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 25, 2024
breezewish and others added 9 commits November 25, 2024 20:34
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 28, 2024
Signed-off-by: Wish <[email protected]>
breezewish and others added 3 commits November 28, 2024 11:54
Signed-off-by: Wish <[email protected]>
…pingcap/docs into wenxuan/vector-serverless

* 'wenxuan/vector-serverless' of ssh://ssh.github.com:443/pingcap/docs:
  Update tidb-cloud/vector-search-limitations.md
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2024
@qiancai qiancai added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Nov 28, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 28, 2024
Copy link
Member

@Icemap Icemap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2024
Copy link

ti-chi-bot bot commented Nov 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-28 06:57:02.454635719 +0000 UTC m=+706010.074290235: ☑️ agreed by qiancai.
  • 2024-11-28 07:21:23.177766298 +0000 UTC m=+707470.797420813: ☑️ agreed by Icemap.

@qiancai
Copy link
Collaborator

qiancai commented Nov 28, 2024

/approve

Copy link

ti-chi-bot bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 28, 2024
@ti-chi-bot ti-chi-bot bot merged commit d651616 into release-7.5 Nov 28, 2024
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19519.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tidb-cloud This PR relates to the area of TiDB Cloud. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

note for TiDB Vector Search
5 participants