Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mintso config parameters #19452

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Add mintso config parameters #19452

merged 6 commits into from
Nov 20, 2024

Conversation

xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Nov 19, 2024 •
edited by lilin90
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 19, 2024
@lilin90 lilin90 added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Nov 19, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 19, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 19, 2024
@lilin90 lilin90 requested a review from windtalker November 19, 2024 04:02
@lilin90 lilin90 added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Nov 19, 2024
lilin90
lilin90 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-19 04:04:33.592268289 +0000 UTC m=+933835.783137286: ☑️ agreed by lilin90.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 19, 2024
windtalker
windtalker approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 20, 2024
@lilin90 lilin90 added the lgtm label Nov 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit 397721d into pingcap:master Nov 20, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #19462.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 20, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #19463.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 20, 2024
@xzhangxian1008 @ti-chi-bot
This is an automated cherry-pick of pingcap#19452
6ca74de 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 20, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #19464.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 20, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #19465.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 20, 2024
@xzhangxian1008 @ti-chi-bot
This is an automated cherry-pick of pingcap#19452
44f0170 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 20, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #19466.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 20, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19467.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 20, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #19468.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 20, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #19469.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 20, 2024
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 21, 2024
@ti-chi-bot
Add mintso config parameters (#19452) (#19462)
dd98c96
ti-chi-bot bot pushed a commit that referenced this pull request Nov 21, 2024
@ti-chi-bot
Add mintso config parameters (#19452) (#19469)
cf723fa
ti-chi-bot bot pushed a commit that referenced this pull request Nov 21, 2024
@ti-chi-bot
Add mintso config parameters (#19452) (#19468)
1bf8bb2
ti-chi-bot bot pushed a commit that referenced this pull request Nov 21, 2024
@ti-chi-bot
Add mintso config parameters (#19452) (#19467)
1eae9d6
ti-chi-bot bot pushed a commit that referenced this pull request Nov 21, 2024
@ti-chi-bot
Add mintso config parameters (#19452) (#19466)
9321695
ti-chi-bot bot pushed a commit that referenced this pull request Nov 21, 2024
@ti-chi-bot
Add mintso config parameters (#19452) (#19465)
67d42cf
ti-chi-bot bot pushed a commit that referenced this pull request Nov 21, 2024
@ti-chi-bot
Add mintso config parameters (#19452) (#19463)
3424bd0
ti-chi-bot bot pushed a commit that referenced this pull request Nov 21, 2024
@ti-chi-bot
Add mintso config parameters (#19452) (#19464)
c162864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@windtalker windtalker windtalker approved these changes

Assignees

@lilin90 lilin90

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xzhangxian1008 @lilin90 @ti-chi-bot @windtalker