store limit v2: add more experimental description #19131

lhy1024 · 2024-11-20T06:13:56Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

lhy1024 · 2024-11-20T06:15:23Z

configure-store-limit.md

+在该模式下，TiKV 执行速度成为迁移进度的主要瓶颈。你可以通过 **TiKV Details** > **Snapshot** > **Snapshot Speed** 面板判断当前调度速度是否达到 TiKV 限流设置。通过调整 TiKV Snapshot Limit ([`snap-io-max-bytes-per-sec`](/tikv-configuration-file.md#snap-io-max-bytes-per-sec)) 来增加或减少该节点的调度速度。
+
+在当前版本中，将该配置项设置为 `"v2"` 为实验特性，不建议在生产环境中使用。


from

docs-cn/pd-configuration-file.md

Line 430 in 148b399

> 在当前版本中，将该配置项设置为 `"v2"` 为实验特性，不建议在生产环境中使用。

This feature is experimental between 7.1 and 8.5, and will GA in 8.5

This feature is experimental between 7.1 and 8.5, and will GA in 8.5

@lhy1024 I recommend:

Changing the base of this PR to release-8.4 or release-7.1. I will cherry-pick this PR to v7.1 and later versions.

Creating a new PR to upadte the master branch for v8.5 changes: removing the experimental note in

docs-cn/pd-control.md

Line 457 in 3c0975e

- `store-limit-version` 用于设置 `store limit` 限制模式，目前提供两种方式：`v1` 和 `v2`。默认值为 `v1`。在 `v1` 模式下，你可以手动修改 `store limit` 以限制单个 TiKV 调度速度。`v2` 模式为实验特性，不建议在生产环境中使用。在 `v2` 模式下，你无需关注 `store limit` 值，PD 将根据 TiKV Snapshot 执行情况动态调整 TiKV 调度速度。详情请参考 [Store Limit v2 原理](/configure-store-limit.md#store-limit-v2-原理)。

configure-store-limit.md

pd-control.md

configure-store-limit.md

lhy1024 · 2024-11-22T08:36:01Z

releases/release-7.1.0.md

@@ -386,7 +386,7 @@ TiDB 7.1.0 为长期支持版本 (Long-Term Support Release, LTS)。

 + PD

-    - 新增基于 snapshot 执行细节来自动调整 store limit 大小的控制器。将 `store-limit-version` 设置为 `v2` 即可开启该控制器，开启后，用户无需手动调整 `store limit` 配置来控制扩缩容的速度 [#6147](https://github.com/tikv/pd/issues/6147) @[bufferflies](https://github.com/bufferflies)
+    - 新增基于 snapshot 执行细节来自动调整 store limit 大小的控制器（实验特性）。将 `store-limit-version` 设置为 `v2` 即可开启该控制器，开启后，用户无需手动调整 `store limit` 配置来控制扩缩容的速度 [#6147](https://github.com/tikv/pd/issues/6147) @[bufferflies](https://github.com/bufferflies)


@Oreoxmt PTAL

Signed-off-by: lhy1024 <[email protected]>

ti-chi-bot · 2024-12-05T03:01:42Z

@niubell: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2024-12-05T03:31:38Z

[LGTM Timeline notifier]

Timeline:

2024-11-25 06:10:10.367788887 +0000 UTC m=+443997.987443402: ☑️ agreed by Oreoxmt.
2024-12-05 03:31:37.72877961 +0000 UTC m=+1298485.348434124: ☑️ agreed by qiancai.

Oreoxmt · 2024-12-05T03:46:19Z

/approve

ti-chi-bot · 2024-12-05T03:46:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Oreoxmt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-12-05T03:57:12Z

In response to a cherrypick label: new pull request created to branch release-8.3: #19209.

ti-chi-bot · 2024-12-05T03:57:50Z

In response to a cherrypick label: new pull request created to branch release-7.1: #19210.

ti-chi-bot · 2024-12-05T03:58:29Z

In response to a cherrypick label: new pull request created to branch release-7.5: #19211.

ti-chi-bot · 2024-12-05T03:59:08Z

In response to a cherrypick label: new pull request created to branch release-8.1: #19212.

ti-chi-bot · 2024-12-05T03:59:47Z

In response to a cherrypick label: new pull request created to branch release-8.2: #19213.

lhy1024 requested a review from qiancai November 20, 2024 06:14

ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Nov 20, 2024

lhy1024 requested a review from niubell November 20, 2024 06:14

ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2024

lhy1024 commented Nov 20, 2024

View reviewed changes

Oreoxmt self-requested a review November 22, 2024 03:36

Oreoxmt self-assigned this Nov 22, 2024

Oreoxmt added the translation/doing This PR’s assignee is translating this PR. label Nov 22, 2024

ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 22, 2024

Oreoxmt reviewed Nov 22, 2024

View reviewed changes

configure-store-limit.md Show resolved Hide resolved

configure-store-limit.md Outdated Show resolved Hide resolved

pd-control.md Outdated Show resolved Hide resolved

Oreoxmt reviewed Nov 22, 2024

View reviewed changes

configure-store-limit.md Show resolved Hide resolved

lhy1024 commented Nov 22, 2024

View reviewed changes

Oreoxmt approved these changes Nov 25, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 25, 2024

Oreoxmt added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 3, 2024

lhy1024 changed the base branch from master to release-8.4 December 3, 2024 03:16

ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2024

store limit v2: add more experimental description

4de6bb9

Signed-off-by: lhy1024 <[email protected]>

lhy1024 force-pushed the store-limit-v2 branch from 35511e3 to 4de6bb9 Compare December 3, 2024 03:33

ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 3, 2024

Oreoxmt removed needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Dec 3, 2024

niubell approved these changes Dec 5, 2024

View reviewed changes

qiancai approved these changes Dec 5, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2024

ti-chi-bot bot added the approved label Dec 5, 2024

ti-chi-bot bot merged commit 583beca into pingcap:release-8.4 Dec 5, 2024
6 of 7 checks passed

ti-chi-bot mentioned this pull request Dec 5, 2024

store limit v2: add more experimental description (#19131) #19209

Merged

17 tasks

ti-chi-bot mentioned this pull request Dec 5, 2024

store limit v2: add more experimental description (#19131) #19210

Merged

17 tasks

ti-chi-bot mentioned this pull request Dec 5, 2024

store limit v2: add more experimental description (#19131) #19211

Merged

17 tasks

ti-chi-bot mentioned this pull request Dec 5, 2024

store limit v2: add more experimental description (#19131) #19212

Merged

17 tasks

ti-chi-bot mentioned this pull request Dec 5, 2024

store limit v2: add more experimental description (#19131) #19213

Merged

17 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2024

store limit v2: add more experimental description (#19131) (#19212)

c16c98b

ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2024

store limit v2: add more experimental description (#19131) (#19211)

59460f6

ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2024

store limit v2: add more experimental description (#19131) (#19213)

acf65ac

ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2024

store limit v2: add more experimental description (#19131) (#19209)

201c36b

ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2024

store limit v2: add more experimental description (#19131) (#19210)

4a5159a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

store limit v2: add more experimental description #19131

store limit v2: add more experimental description #19131

lhy1024 commented Nov 20, 2024 •

edited

Loading

lhy1024 Nov 20, 2024

lhy1024 Nov 22, 2024

Oreoxmt Nov 22, 2024 •

edited

Loading

lhy1024 Nov 22, 2024

ti-chi-bot bot commented Dec 5, 2024

ti-chi-bot bot commented Dec 5, 2024

Oreoxmt commented Dec 5, 2024

ti-chi-bot bot commented Dec 5, 2024

ti-chi-bot commented Dec 5, 2024

ti-chi-bot commented Dec 5, 2024

ti-chi-bot commented Dec 5, 2024

ti-chi-bot commented Dec 5, 2024

ti-chi-bot commented Dec 5, 2024

		在该模式下，TiKV 执行速度成为迁移进度的主要瓶颈。你可以通过 TiKV Details > Snapshot > Snapshot Speed 面板判断当前调度速度是否达到 TiKV 限流设置。通过调整 TiKV Snapshot Limit ([`snap-io-max-bytes-per-sec`](/tikv-configuration-file.md#snap-io-max-bytes-per-sec)) 来增加或减少该节点的调度速度。

		在当前版本中，将该配置项设置为 `"v2"` 为实验特性，不建议在生产环境中使用。

store limit v2: add more experimental description #19131

store limit v2: add more experimental description #19131

Conversation

lhy1024 commented Nov 20, 2024 • edited Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

lhy1024 Nov 20, 2024

Choose a reason for hiding this comment

lhy1024 Nov 22, 2024

Choose a reason for hiding this comment

Oreoxmt Nov 22, 2024 • edited Loading

Choose a reason for hiding this comment

lhy1024 Nov 22, 2024

Choose a reason for hiding this comment

ti-chi-bot bot commented Dec 5, 2024

ti-chi-bot bot commented Dec 5, 2024

[LGTM Timeline notifier]

Oreoxmt commented Dec 5, 2024

ti-chi-bot bot commented Dec 5, 2024

ti-chi-bot commented Dec 5, 2024

ti-chi-bot commented Dec 5, 2024

ti-chi-bot commented Dec 5, 2024

ti-chi-bot commented Dec 5, 2024

ti-chi-bot commented Dec 5, 2024

lhy1024 commented Nov 20, 2024 •

edited

Loading

Oreoxmt Nov 22, 2024 •

edited

Loading