Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for deprecate-integer-display-length=true #19114

Merged

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Nov 18, 2024

What is changed, added or deleted? (Required)

Update the docs to follow the change in default value for deprecate-integer-display-length.

This follows the behavior in MySQL.

Integer types can be defined like int(10) or int(8) or int. People often misunderstand the meaning of the number that is specified here (e.g. the 10 and the 8 here). This does not change the capacity of the value that can be stored it only changes how it might be displayed.

See also https://dev.mysql.com/doc/refman/8.0/en/numeric-type-attributes.html and pingcap/tidb#56529

Important: This changes the documentation for the variable and updates the page describing numeric types. However this does NOT update the output that might have changed.

Output that changes based on this variable:

  • SHOW CREATE TABLE
  • DESCRIBE <table>, EXPLAIN <table> and SHOW COLUMNS FROM ...
  • EXPLAIN...

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Don't merge before this PR has been merged
pingcap/tidb#56529

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added for-release This PR relates to a TiDB release but does not have a tracked feature. translation/from-docs This PR is translated from a PR in pingcap/docs. v8.5 labels Nov 18, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2024
@qiancai qiancai self-assigned this Nov 18, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2024
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt self-requested a review November 19, 2024 01:03
Copy link

ti-chi-bot bot commented Nov 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-19 03:28:23.53956853 +0000 UTC m=+931665.730437528: ☑️ agreed by Oreoxmt.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 19, 2024
@qiancai
Copy link
Collaborator Author

qiancai commented Nov 26, 2024

/approve

@qiancai qiancai added the lgtm label Nov 26, 2024
Copy link

ti-chi-bot bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit a62c525 into pingcap:master Nov 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs. v8.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants