-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for deprecate-integer-display-length=true #19114
Merged
ti-chi-bot
merged 5 commits into
pingcap:master
from
qiancai:deprecate-integer-display-length-19159
Nov 26, 2024
Merged
Update docs for deprecate-integer-display-length=true #19114
ti-chi-bot
merged 5 commits into
pingcap:master
from
qiancai:deprecate-integer-display-length-19159
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiancai
added
for-release
This PR relates to a TiDB release but does not have a tracked feature.
translation/from-docs
This PR is translated from a PR in pingcap/docs.
v8.5
labels
Nov 18, 2024
ti-chi-bot
bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Nov 18, 2024
ti-chi-bot
bot
added
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Nov 18, 2024
qiancai
commented
Nov 18, 2024
qiancai
commented
Nov 18, 2024
Oreoxmt
approved these changes
Nov 19, 2024
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
for-release
This PR relates to a TiDB release but does not have a tracked feature.
lgtm
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
translation/from-docs
This PR is translated from a PR in pingcap/docs.
v8.5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Update the docs to follow the change in default value for
deprecate-integer-display-length
.This follows the behavior in MySQL.
Integer types can be defined like
int(10)
orint(8)
orint
. People often misunderstand the meaning of the number that is specified here (e.g. the 10 and the 8 here). This does not change the capacity of the value that can be stored it only changes how it might be displayed.See also https://dev.mysql.com/doc/refman/8.0/en/numeric-type-attributes.html and pingcap/tidb#56529
Important: This changes the documentation for the variable and updates the page describing numeric types. However this does NOT update the output that might have changed.
Output that changes based on this variable:
SHOW CREATE TABLE
DESCRIBE <table>
,EXPLAIN <table>
andSHOW COLUMNS FROM ...
EXPLAIN...
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Don't merge before this PR has been merged
pingcap/tidb#56529
Do your changes match any of the following descriptions?