Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb: add description for var tidb_ddl_reorg_max_write_speed #19071

Merged
merged 8 commits into from
Nov 26, 2024
Merged

tidb: add description for var tidb_ddl_reorg_max_write_speed #19071

merged 8 commits into from
Nov 26, 2024

Conversation

CbcWestwolf
Copy link
Member

What is changed, added or deleted? (Required)

add description for var tidb_ddl_reorg_max_write_speed

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2024
@qiancai qiancai added v8.5 translation/doing This PR’s assignee is translating this PR. labels Nov 14, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 14, 2024
@qiancai qiancai self-assigned this Nov 14, 2024
@qiancai qiancai added the for-release This PR relates to a TiDB release but does not have a tracked feature. label Nov 14, 2024
@qiancai qiancai self-requested a review November 14, 2024 06:02
tangenta
tangenta reviewed Nov 14, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 14, 2024
qiancai
qiancai reviewed Nov 18, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
CbcWestwolf and others added 2 commits November 18, 2024 10:31
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 18, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-14 07:34:29.249435206 +0000 UTC m=+514431.440304187: ☑️ agreed by tangenta.
  • 2024-11-18 05:53:12.260242456 +0000 UTC m=+853954.451111452: ☑️ agreed by qiancai.

@CbcWestwolf CbcWestwolf mentioned this pull request Nov 18, 2024
Merged
16 tasks
@hfxsd hfxsd mentioned this pull request Nov 18, 2024
Merged
17 tasks
hfxsd
hfxsd reviewed Nov 18, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@hfxsd hfxsd added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Nov 18, 2024
@Oreoxmt Oreoxmt self-requested a review November 19, 2024 01:03
Oreoxmt
Oreoxmt reviewed Nov 19, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

qiancai
qiancai reviewed Nov 22, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
qiancai
qiancai reviewed Nov 26, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@qiancai
Copy link
Collaborator

qiancai commented Nov 26, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit 5415893 into pingcap:master Nov 26, 2024
7 checks passed
@CbcWestwolf CbcWestwolf deleted the ddl_ingest_write_limit branch November 28, 2024 07:41
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 2, 2024
Merged
17 tasks
@CbcWestwolf
Copy link
Member Author

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@CbcWestwolf: new pull request created to branch release-7.5: #19255.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

This was referenced Dec 10, 2024
Open
Open
@CbcWestwolf
Copy link
Member Author

/cherry-pick release-6.5
/cherry-pick release-7.1
/cherry-pick release-8.1

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 10, 2024
Open
16 tasks
@ti-chi-bot
Copy link
Member

@CbcWestwolf: new pull request created to branch release-6.5: #19256.

In response to this:

/cherry-pick release-6.5
/cherry-pick release-7.1
/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

This was referenced Dec 10, 2024
Open
Open
@ti-chi-bot
Copy link
Member

@CbcWestwolf: new pull request created to branch release-7.1: #19257.

In response to this:

/cherry-pick release-6.5
/cherry-pick release-7.1
/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

This was referenced Dec 10, 2024
Open
Open
@ti-chi-bot
Copy link
Member

@CbcWestwolf: new pull request created to branch release-8.1: #19258.

In response to this:

/cherry-pick release-6.5
/cherry-pick release-7.1
/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 10, 2024
Open
16 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@hfxsd hfxsd hfxsd left review comments

@tangenta tangenta tangenta approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@qiancai qiancai

Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CbcWestwolf @qiancai @ti-chi-bot @tangenta @hfxsd @Oreoxmt