Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb-binlog: add summary to docs #16962

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Apr 1, 2024

What is changed, added or deleted? (Required)

Add summary to tidb-binlog/*.md

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added the translation/no-need No need to translate this PR. label Apr 1, 2024
Copy link

ti-chi-bot bot commented Apr 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2024
Copy link

ti-chi-bot bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oreoxmt, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 1, 2024
@Oreoxmt Oreoxmt removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2024
@Oreoxmt Oreoxmt marked this pull request as ready for review April 1, 2024 10:53
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Apr 3, 2024

/cc @lilin90

@ti-chi-bot ti-chi-bot bot requested a review from lilin90 April 3, 2024 05:12
tidb-binlog/binlog-consumer-client.md Outdated Show resolved Hide resolved
tidb-binlog/deploy-tidb-binlog.md Outdated Show resolved Hide resolved
tidb-binlog/maintain-tidb-binlog-cluster.md Outdated Show resolved Hide resolved
tidb-binlog/tidb-binlog-configuration-file.md Outdated Show resolved Hide resolved
tidb-binlog/tidb-binlog-faq.md Outdated Show resolved Hide resolved
tidb-binlog/tidb-binlog-overview.md Outdated Show resolved Hide resolved
tidb-binlog/tidb-binlog-relay-log.md Outdated Show resolved Hide resolved
tidb-binlog/troubleshoot-tidb-binlog.md Outdated Show resolved Hide resolved
tidb-binlog/upgrade-tidb-binlog.md Outdated Show resolved Hide resolved
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 4, 2024
Copy link

ti-chi-bot bot commented Apr 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-04 13:58:00.396764805 +0000 UTC m=+538741.924305349: ☑️ agreed by lilin90.

@lilin90 lilin90 merged commit 27c0d12 into pingcap:add-summary Apr 4, 2024
2 checks passed
@Oreoxmt Oreoxmt deleted the summary/tidb-binlog branch December 31, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants