Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#110 Change auth to session. #91

Merged
merged 32 commits into from
Jun 11, 2024
Merged

#110 Change auth to session. #91

merged 32 commits into from
Jun 11, 2024

Conversation

martineiber
Copy link
Contributor

@martineiber martineiber commented Jun 5, 2024

Changes in this pull request

Part of pimcore/studio-ui-bundle#110

Additional info

Update your security.yaml in your project:

security:
    firewalls: 
        pimcore_studio: '%pimcore_studio_backend.firewall_settings%'
    access_control:
        - { path: ^/studio/api/(docs|docs.json|translations)$, roles: PUBLIC_ACCESS }
        - { path: ^/studio, roles: ROLE_PIMCORE_USER }

@fashxp
Copy link
Member

fashxp commented Jun 5, 2024

please add firewall info to readme file too

@mattamon
Copy link
Contributor

mattamon commented Jun 5, 2024

Repo is now public, comments can be seen by everyone :) We should stick to english

@fashxp
Copy link
Member

fashxp commented Jun 5, 2024

Repo is now public, comments can be seen by everyone :) We should stick to english

ups, you're right 😄

@martineiber martineiber changed the title #110 [WIP] Change auth to session. #110 Change auth to session. Jun 6, 2024
@martineiber martineiber marked this pull request as ready for review June 6, 2024 05:06
@martineiber martineiber requested a review from mattamon June 6, 2024 05:06
Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm :)

config/authorization.yaml Outdated Show resolved Hide resolved
src/Authorization/Controller/LoginController.php Outdated Show resolved Hide resolved
src/Authorization/EventListener/LogoutListener.php Outdated Show resolved Hide resolved
src/Security/Service/SecurityService.php Show resolved Hide resolved
Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦭

@martineiber
Copy link
Contributor Author

We will keep this PR open until the FE Part is ready to merge. Otherwise we will break the FE.

# Conflicts:
#	src/Version/Controller/PublishController.php
Copy link

sonarcloud bot commented Jun 11, 2024

@martineiber martineiber merged commit 0232321 into 1.x Jun 11, 2024
9 checks passed
@martineiber martineiber deleted the 110-auth-to-session branch June 11, 2024 10:00
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants