Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Introduce lifetime and hubservice #236

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Conversation

mattamon
Copy link
Contributor

@mattamon mattamon commented Jul 9, 2024

Changes in this pull request

Resolves #185

Additional info

Refactoring cookie creation and introducing lifetime

@mattamon mattamon added the Task label Jul 9, 2024
@mattamon mattamon requested a review from lukmzig July 9, 2024 07:02
Copy link
Contributor

@lukmzig lukmzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦭

Copy link

sonarcloud bot commented Jul 9, 2024

@mattamon mattamon merged commit cf9a1be into 1.x Jul 9, 2024
13 checks passed
@mattamon mattamon deleted the 185-cookie-lifetime branch July 9, 2024 08:14
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add cookie lifetime to mercure settings Follow up Mercure
2 participants