Skip to content

Commit

Permalink
[ColumnFilter] Trim whitespace for filterValue (#567)
Browse files Browse the repository at this point in the history
* Trim Filter Value.

* Apply php-cs-fixer changes

---------

Co-authored-by: martineiber <[email protected]>
  • Loading branch information
martineiber and martineiber authored Nov 22, 2024
1 parent 47dec90 commit ea13cd8
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/MappedParameter/Filter/SimpleColumnFilter.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

namespace Pimcore\Bundle\StudioBackendBundle\MappedParameter\Filter;

use function is_string;

/**
* @internal
*/
Expand All @@ -34,6 +36,10 @@ public function getType(): string

public function getFilterValue(): mixed
{
if (is_string($this->filterValue)) {
return trim($this->filterValue);
}

return $this->filterValue;
}
}
40 changes: 40 additions & 0 deletions tests/Unit/MappedParameter/Filter/SimpleColumnFilterTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
<?php
declare(strict_types=1);

/**
* Pimcore
*
* This source file is available under two different licenses:
* - GNU General Public License version 3 (GPLv3)
* - Pimcore Commercial License (PCL)
* Full copyright and license information is available in
* LICENSE.md which is distributed with this source code.
*
* @copyright Copyright (c) Pimcore GmbH (http://www.pimcore.org)
* @license http://www.pimcore.org/license GPLv3 and PCL
*/

namespace Pimcore\Bundle\StudioBackendBundle\Tests\Unit\MappedParameter\Filter;

use Codeception\Test\Unit;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\Filter\SimpleColumnFilter;

/**
* @internal
*/
final class SimpleColumnFilterTest extends Unit
{
public function testTrimFilterValue(): void
{
$filter = new SimpleColumnFilter('type', ' value ');

$this->assertSame('value', $filter->getFilterValue());
}

public function testGetFilterValue(): void
{
$filter = new SimpleColumnFilter('type', ['value']);

$this->assertSame(['value'], $filter->getFilterValue());
}
}

0 comments on commit ea13cd8

Please sign in to comment.