Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Upgrade dependencies #440

Open
wants to merge 3 commits into
base: 1.x
Choose a base branch
from
Open

[Task] Upgrade dependencies #440

wants to merge 3 commits into from

Conversation

mattamon
Copy link
Contributor

No description provided.

@blankse
Copy link
Contributor

blankse commented Nov 26, 2024

@mattamon I think you can cleanup following things:

  • Remove require_admin_bundle options in matrix
  • Remove REQUIRE_ADMIN_BUNDLE env in "Setup Pimcore environment" steps
  • Remove Lines 16-22 in .github/ci/scripts/setup-pimcore-environment.sh
  • Remove file .github/ci/files/security.yaml

@mattamon
Copy link
Contributor Author

@mattamon I think you can cleanup following things:

  • Remove require_admin_bundle options in matrix
  • Remove REQUIRE_ADMIN_BUNDLE env in "Setup Pimcore environment" steps
  • Remove Lines 16-22 in .github/ci/scripts/setup-pimcore-environment.sh
  • Remove file .github/ci/files/security.yaml

yeah I am on it already, wanted to check the tests first

Copy link

sonarcloud bot commented Nov 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants