Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to serialize csv using row header #433

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Add option to serialize csv using row header #433

merged 2 commits into from
Nov 22, 2024

Conversation

cancan101
Copy link
Contributor

Closes #412

@mcop1 mcop1 self-assigned this Nov 15, 2024
@mcop1 mcop1 added this to the 1.10.0 milestone Nov 15, 2024
mcop1
mcop1 reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@mcop1 mcop1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

thank you for your contribution, looks good. I would just have 2 really small 2 remarks. Could you please have a look?

Thank you for your efforts.

src/DataSource/Interpreter/CsvFileInterpreter.php Outdated Show resolved Hide resolved
src/DataSource/Interpreter/CsvFileInterpreter.php Show resolved Hide resolved
@cancan101 @mcop1
Use native types
ab4ee77 
Co-authored-by: mcop1 <[email protected]>
@mcop1 mcop1 merged commit 3d28325 into pimcore:1.x Nov 22, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcop1 mcop1 mcop1 left review comments

Assignees

@mcop1 mcop1

Labels
Pimcore:ToDo
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

[Feature]: CSV Data Source with skipFirstRow should use row headings rather than row index
3 participants
@cancan101 @mcop1 @wisconaut