Added Structured Table Type #353
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
| */ | ||
| public function evaluateReturnType(string $inputType, int $index = null): string | ||
| { | ||
| return TransformationDataTypeService::DEFAULT_ARRAY; |
There was a problem hiding this comment.
we would need to introduce there an extra type which just allows assignment to structured table fields, like we have it for quantity value, gallery etc.
| 'languages' | ||
| 'languages', | ||
| 'table', | ||
| 'structuredTable' |
There was a problem hiding this comment.
should be moved to an extra type...
| if (empty($inputData)) { | ||
| return ""; | ||
| } | ||
| return (new StructuredTable($inputData))->getHtmlTable( |
There was a problem hiding this comment.
Why return a html table here?
Shouldn't be that in generateResultPreview, as for example here
| 'key' => $value, | ||
| 'label' => $label, | ||
| ]; | ||
| }, array_keys($inputData), array_keys(array_values($inputData)[0])), |
There was a problem hiding this comment.
$inputData might be empty/null ... will result in errors at this place.
|
@mybabysexy 🏓 did you already have a chance to take a look at my comments? |
|
@mybabysexy 🏓 any chance we could continue the discussion here? |
hi, sorry I'm no longer working with Pimcore or PHP so I don't think that I can continue with this PR |
thx for the information. |
|
closing due to inactivity |
Implement #101