Add Finnish translation #202
Conversation
|
|
👇 Click on the image for a new way to code review
Legend |
|
Dear @minna-xD , this is a great surprise, thank you for doing this! I will set up a test installation and have a short visual review today and report back whether i spotted any layout issues. Of course I can add that label to the pull request, I just didn't know about Hacktoberfest before. Thanks for pointing me to it! |
|
Dear @minna-xD , I have started reviewing it visually and found some small issues (see the attached screenshot gallery):
In addition to having a look at the screenshots, you can go to https://pik-gane.github.io/vodle/#/joinpoll/https%3A%2F%2Fsandstorm.pik-potsdam.de%2Fcouch%2F/none/96c565d3/b169f7eb4fe7929b and log in with a guest account to see a test poll. Another question: I am not very experienced with translations but had the feeling that the Crowdin tool was very helpful, and some others have used it in our project. As you have decided not to use it, I'd like to ask if there was any specific reason for it, such as some drawback of Crowdin that I'm not aware of. |
I used the term 'kannatusluku' which is like 'amount of support' (but now I see I missed a couple of cases with 'kannatuksesi/kannatus' when I was harmonizing my final terminology). Wap is slighly strange for Finns, especially since 'w' is not our native letter. I will do some more reading of your materials to "ruminate" on a better term suggestion.
This was a misunderstanding of context. It seemed like there would be a word first that would, if used in a normal sentence, require inflection. I will fix accordingly!
Yes, Finnish uses a space before the percent sign. Actually, if possible, I suppose it would be best to even use a non-breaking space (either the HTML entity if that works, or some other notation). About Crowdin, I actually didn't realize this project was available there! On the Contributions page it says "We will soon provide detailed information on this... in the meantime, please look at the JSON files". I've used Crowdin just recently on another translation and I think it is a really useful tool and would be happy to use it. I understand it would be possible to upload/sync into Crowdin also a file translated elsewhere (so that the work is not lost)..? Thank you for the screenshots and the link! I will take a look at the localization tonight and make improvements. |
What is important is that "wap" is not confused with "approval". In vodle, the voter does not state directly whether they approve an option or not. Their approval is rather calculated on the basis of their (and the others') "willingness to approve". So we need two clearly different words for "wap" and "approval". |
OK, then let's leave it as it is for now and I will think of improving the spacing later :-) |
Oh gosh, then I'm sorry for my bad documentation. I will update that then asap. I will try loading your translation into Crowdin later today. |
So that was easier than I thought: You should be able to access your translations and work on them directly in Crowdin here: https://crowdin.com/translate/vodle/10/en-fi?filter=basic&value=0 |
|
Looking at Crowdin now, it is a bit of a problem how the file looks in the editor. A lot of the context (especially for chopped up sentences), comments and proper order are lost, making it quite difficult for translators to work on. There is the file preview at least, but in best case the source file would be visible to translators all the time due to the way it has been structured. JSON files (well, software resources in general, I suppose) are tricky ones to handle in translation tools because they don't really have any semantic structure and tools don't necessarily know what the order of strings should be (alphabetical by key/text, in original order...). i18n in itself is an artform for software texts with formatting, variables etc. and there are some rules of thumb that make it easier (such as keeping sentences intact) but that is a whole different endeavour. I can finalize my current translation in Crowdin, but in the long term I would suggest looking for another solution for the localization. It's been a while since my translation&localization agency days so I'm not able to give a good alternative (especially a free one) but I guess I could dig around a bit if something promising catches my eye. |
|
Hi again, @minna-xD . Feel free to continue working on the JSON file directly! I believe in Crowdin, if you select the filter "Show all", then the order of strings shown is the same as in the JSON file. Also, the hierarchical organization is shown as the "context" (see here on the right): But I agree it would be good if the JSON file itself could be placed somewhere optionally. Maybe we should just suggest this to the Crowdin developers as a feature request? Regarding the chopped-up sentences, I also feel a little bad about them. The main reason for those is the large amount of variable stuff, including formatting, going in between the text snippets. I will look out for a better way to encode those so that the sentences stay intact in the JSON file, using placeholders. As you hinted at having worked professionally in a translation agency: Can you recommend a best practice for acquiring reviewers and managing the review process? |
OK, I have done so and made a new commit with changes. After ruminating, I've made the following changes to core terminology: I also looked through the screenshots, the live app and your observations above and fixed as necessary. Change request: In the language selection menu, could you change "Suomea" to "Suomi"? Thank you! It seems to come from an external (to the JSON) source.
Correct, it helps. 👍🏻
Why not! A live preview (even a rudimentary one) on the side would help with many file formats.
I will get back to you on that with fresh brain! |
|
Moin @minna-xD , that sounds like a viable way. Is it OK to hyphenate like this to make the words fit into the space (I already reduced the font-size a bit): I also saw you did some edits in Crowdin. Just to be sure: Are those also already included in the JSON file in this PR? If yes, then I would remove the Crowdin file to make sure there is no conflict. |
|
Yes! Crowdin content is now outdated. All changes are in the file for this PR. For hyphenation, I suggest: |
There was a problem hiding this comment.
Thanks, @minna-xD , for your valuable work and hints on the translation workflow. I have added the hacktoberfest-accepted label now and will merge the PR into main as soon as I have found some other speaker of Finnish to have a look.
|
@minna-xD , is it possible for you to sign your commits? (maybe this way: https://superuser.com/questions/397149/can-you-gpg-sign-old-commits) Otherwise I will have to bypass the branch protection rule... |
Working on it..! 🕵🏻♀️ |
minna-xD
force-pushed
the
finnish-translation
branch
from
d21da68 to
482f702
Compare
|
Oh man, I'm not doing well with git. 🤦🏻 There are a lot of new concepts for me here (signing and reviewing) and now I managed to dismiss your review. It was looking better earlier but there was still something unsigned so it was still blocked (or so it seemed). |
|
don't worry, we'll sort it out :-) it took me years to understand git and I'm still making stupid mistakes :-)
Am 18. Oktober 2022 21:20:10 MESZ schrieb "Minna N." ***@***.***>:
…Oh man, I'm not doing well with git. 🤦🏻 There are a lot of new
concepts for me here (signing and reviewing) and now I managed to
dismiss your review. It was looking better earlier but there was still
something unsigned so it was still blocked.>
>
-- >
Reply to this email directly or view it on GitHub:>
#202 (comment)>
You are receiving this because your review was requested.>
>
Message ID: ***@***.***>
--
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
|
Greetings from Finland!
I was looking for projects accepting translations and happened to find this one. Such a wonderful application you have here! I've translated the strings to Finnish.
I'm taking part in Hacktoberfest, which is a month-long celebration of open source where people are encouraged to contribute to open source projects. When I found this project, I didn't even realize it was not taking part in Hacktoberfest (nowadays it's opt-in only), I was so excited to get started.
I hope you would consider marking this pull request, if you find it acceptable, with label hacktoberfest-accepted (sometime before the end of October). That would help me reach my goal. Thank you very much in advance!