Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle incomingCallEnded() separately. #391

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

jmlich
Copy link
Contributor

@jmlich jmlich commented Aug 24, 2024

This should avoid extra notification on PineTime (closes #297)
Additionally, it should remove notification on bangle.js when call is ended. I have implemented that blindly, it would be great if someone can test it.
Additionally, it adds the same feature on AsteroidOS.

@jmlich jmlich force-pushed the incommingCallEnded branch from 6a65536 to 6aa2b1c Compare August 24, 2024 13:42
This avoids extra notification on PineTime (closes piggz#297)
@jmlich jmlich force-pushed the incommingCallEnded branch from 6aa2b1c to e5e34fb Compare August 24, 2024 13:42
@piggz piggz merged commit 40ee174 into piggz:master Aug 26, 2024
3 checks passed
@jmlich jmlich deleted the incommingCallEnded branch September 13, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImediateAlertService::NoAlert doesn't dissmiss phone call on PineTime
2 participants