-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add caching to the github workflows #189
Open
neilenns
wants to merge
67
commits into
pierr3:main
Choose a base branch
from
neilenns:neilenns/issue185
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierr3
requested changes
Oct 27, 2024
pierr3
requested changes
Nov 5, 2024
This now handles the new libuiohook native dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #185
Our github workflows take around 30 minutes to build right now. This is because of four slow parts:
There's also an additional unnecessary
npm install
step that, while short, does add some time that could be saved and was removed.This PR adds caching for all of those items:
vcpkg.json
and vcpkg submodule SHA as the hash keybackend/
, the afv-native submodule SHA, and the libuiohook submodule SHA, as the hash keyactions/setup-node
package-lock.json
as the hash keyThis cuts the build time down from 30 minutes to around 2 minutes for mac and linux and 3 minutes for windows (which is always slower for some reason).