Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: implemented PlatformPrintJobController.onComplete #2216

Conversation

Doflatango
Copy link
Contributor

Connection with issue(s)

Resolve issue:
Webview can only be disposed when printing job finished, this PR given a chance for listening when printing job get done on Android.

printJobController.printCurrentPage(settings: PrintJobSettings(handledByClient: true));
final completer = Completer();
printJobController.onComplete = (completed, error) async {
    printJobController.dispose();
    completer.complete();
};
await completer.future;
// Webview can only be disposed when printing job finished
headlessInAppWebviewController.dispose();

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@pichillilorenzo pichillilorenzo changed the base branch from v6.0.0 to v6.2.0-beta.3 November 30, 2024 16:26
@pichillilorenzo pichillilorenzo merged commit 68aa382 into pichillilorenzo:v6.2.0-beta.3 Nov 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants