CockroachDB: Hash Sharded Indexes. (#622) #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dantownsend This is the last major addition to complete the Cockroach integration. I separated it out of the main PR to reduce complexity. It's optional, but very highly recommended. I wanted to get feedback on the approach here, if there was a more elegant way to do this. I have to step away for today, but I will get all the linters and such passing shortly. |
dantownsend
reviewed
Oct 11, 2022
Comment on lines
+441
to
+445
| :param sharded: | ||
| If ``True`` and primary_key or index is also set ``True``, this index | ||
| will automatically use sharding across a cluster. Highly recommended | ||
| for sequence columns, such as: Serial, Timestamp. | ||
| Also known as Hash Sharded Index. |
There was a problem hiding this comment.
I would add something here saying 'CockroachDB only'.
If we're likely to have several database specific options, maybe we should namespace them. For example, cockroach_kwargs, or something.
@gnat Cool, no worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #622
Implements "Sharding for Sequential Indexes" as noted in: #607
Major performance feature for "sequential data" for clusters (timestamps, etc).