Skip to content

Commit

Permalink
Don't map C-x C-q to p4-toggle-read-only. Fixes gareth-rees#205.
Browse files Browse the repository at this point in the history
This binding turned a harmless operation (read-only-mode) into a destructive one (p4-revert); additionally, unless your client options included noallwrite, it did not actually make the buffer read-only.
  • Loading branch information
gareth-rees committed Mar 31, 2015
1 parent beac3ec commit 060247b
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions p4.el
Original file line number Diff line number Diff line change
Expand Up @@ -355,14 +355,7 @@ commit command.")

;;; P4 minor mode:

(defvar p4-minor-map
(let ((map (make-sparse-keymap)))
(define-key map "\C-x\C-q" 'p4-toggle-read-only)
map)
"Keymap for P4 minor mode")
(fset 'p4-minor-map p4-minor-map)
(add-to-list 'minor-mode-alist '(p4-mode p4-mode))
(add-to-list 'minor-mode-map-alist '(p4-mode . p4-minor-map))


;;; Keymap:
Expand Down

0 comments on commit 060247b

Please sign in to comment.