Add rule to disallow casting potential null values #225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #224
I've borrowed the
$treatPhpDocTypesAsCertain
logic fromUselessCastRule
.I'm ignoring
mixed
type, as that would be covered by PhpStan itself on level 9.I kept the scope small: there are many more things that could be asserted about casts, such as:
round
/floor
/ceil
instead;(float)[2.00,2.00]
and get1.00
, but should you want to?I figured these cases would be better handled in other rule(s).