Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

[WIP] Refactory & Enhancement #96

Open
wants to merge 45 commits into
base: develop
Choose a base branch
from
Open

[WIP] Refactory & Enhancement #96

wants to merge 45 commits into from

Conversation

feryardiant
Copy link
Member

@feryardiant feryardiant commented Apr 28, 2017 •
edited
Loading

Perubahan

  • Tidak lagi menggunakan folder www sebagai document root & menambahkan folder asset untuk menampung semua file CSS, JS, Fonts & Images.
  • Mengubah codebase, detail perubahan bisa dilihat di tiap commit message.
  • Penggunaan file .env untuk setting dasar. Meminimalisir terjadinya konflik ketika ada perubahan atau penambahan key di file app/settings.php.

Perbaikan

  • Memperbaiki mailer (terkait SMTP connect() failed after member registration #94), disini mailer akan kita ubah dari sebelumnya menggunakan postmark (SMTP) ke sparkpost (ReST API) dimana kelebihan utama dari penggunaan ReST API adalah proses pengiriman email dibebankan ke provider, bukan server production. Selain itu sparkpost juga menawarkan fitur mail marketing secara gratis jadi jika nantinya kita butuh untuk bulk email dapat di-handle oleh sparkpost dengan lebih efisien.
  • Optimasi tampilan pada mobile (terkait Style Issue #80)

Penambahan (Experimental)

  • Optimasi static asset (CSS, JS & Image) dengan tools. Opsi sementara adalah gulp atau webpack.
  • Menggunakan heroku sebagai staging sekaligus meng-enable fitur review, memungkinkan tiap pull request (nantinya) akan ada online demo yang di generate otomatis oleh heroku.
  • Menyediakan testing, walaupun tidak semuanya akan di test tapi setidaknya kita punya fitur ini untuk memastikan berjalan semestinya.

@feryardiant
Merge branch 'develop'
173a199 
* develop:
  Fix notfound routes: - Throw NotFoundException if profile not found, - Experimentaly add custom json request
  Fix missing request method
  Fix missing route
  BC contained updates: - Rename JS files based on its functionalities and make membership.js as central API, - Update routes on Account Skills and Portfolios, make it more convenience to interact with its API, - Add new 'formInputMethod' method in view extension, help method override, - Some updates according changes above.
  Change CSS and JS indentation under www folder to 2 spaces
  Fix ajax city on register page, as per phpindonesia#65
  menghilangkan validasi email pada nama perusahaan
  ajax select city
  Fix error
@feryardiant
Merge branch 'develop'
b42c81c 
* develop:
  Add request json filter
@feryardiant
Merge branch 'develop'
9166b31 
* develop:
  - Fix docblocks
  - Refactor Slim\Container injection in class __construct to ContainerAware trait
  - Concat all middlewares into single class and simplify its usage
@feryardiant
Update dependencies
8e8ec29 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Merge branch 'develop'
e8f65af 
* develop:
  Update www/.htaccess
  Update dependencies
@feryardiant
Update dependencies
087b677 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Fix container docblock
f2ce96a 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
[skip ci] fix merge conflict
75ca754 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Init refactory
c82a334 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Refactor Database namespace
d05b7d3 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Fix docblock
bcca41f 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Fix some issue due to previous commit
005ceb8 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Update homepage url to new phpindonesia.id
ca3aa53 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Update readme.md
759bad6 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Bring back old directory structures with some additional changes
1d7332b 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Update .editorconfig due to latest directory changes
40fd5f3 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Create .env.example
8ff736b 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Update readme & remove setting.php.disabled
801a4e0 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
[refactor] Middleware & Controllers classes now under Memberhsip\Http…
a0c69c7 
… namespace

Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant feryardiant self-assigned this Apr 28, 2017
@feryardiant
Remove Libraries namespace and move all classes to root
732e414 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Register errorHanler first
bb2ca4e 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Fix something due to 732e414
2cc85e5 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Fix controller classes due to a0c69c7
b50b097 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Add app.json for heroku reviews
41125ca 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Add lisence.md
cc187e2 
close phpindonesia#92

Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Add DB_DRIVER envvar
a9c4c04 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Fix some settings
a7328e6 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Patch docblock
82f83e3 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Simplify usage of Models classes
9c113ce 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Extend Slim\Http\Response and inject view engine
0174eda 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Install spackpost client
1cb24d9 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Change mailer container to mail
a43de20 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Update mailer
9783162 
Signed-off-by: Fery Wardiyanto <[email protected]>
@okaprinarjaya
Copy link
Member

Reviewing

@feryardiant
Copy link
Member Author

Thanks om @okaprinarjaya, ada ide apa aja yang perlu dibenahi lagi?

@okaprinarjaya
Copy link
Member

Saya matur suwuunn bangett kepada om @feryardiant , sudah meluangkan waktunya.
apakah ada ide lagi? saya pikir cukup, item-item di section Penambahan (Experimental) adalah ide-ide yg cukup besar dan harus digiring supaya terimplementasi.

Silahkan di-merge om, saya gak berani merge, karena om Fery yg lebih tau apakah PR ini sudah complete atau belom. Atau apakah ada yg butuh ditambahkan lg saya sementara belum tahu.

@feryardiant
Copy link
Member Author

Sami-sami om @okaprinarjaya, kebetulan mumpung saya ada waktu luang weekend ini jadi saya optimalkan untuk ngurusin repo ini (yang sudah saya terlantarkan cukup lama, hiks 😢).

Sementara PR ini masih berstatus WIP & masih ada TODO yang belum selesai tidak akan saya merge dulu sampai saya rasa sudah benar-benar siap. 🥂

@herloct
Copy link

herloct commented May 1, 2017

Menurut ane yg paling penting itu testing-nya dulu oom. Mungkin tepatnya functional atau acceptance testing-nya kali ya, kalo unit atau integration test kayanya rada mubazir kalo liat codebase yg sekarang.

Kalo boleh saran juga, sebaiknya bertahap, sedikit2 langsung​ di-pr n merge, dibanding nunggu banyak n langsung merge sekaligus.
Misal pr pertama ubah struktur direktori, selesai langsung merge.
Trus pr buat functional/acceptance testing, selesai langsung merge.

@herloct
Copy link

herloct commented May 1, 2017

Memperbaiki mailer (terkait #94)...

Yg ini ga langsung di-merge aja oom?

@feryardiant
Copy link
Member Author

Saya perlu memastikan semua todo disini sudah saya selesaikan dulu & maaf kalo mungkin akan sedikit makan waktu.

Saya juga masih ada kendala di salah satu penambahan (eksperimental) fitur yaitu penggunaan Heroku Review App yaitu heroku/heroku-buildpack-php#227

feryardiant added 8 commits May 3, 2017 22:58
@feryardiant
Patch mailer container
6a723e6 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Add ActionResolver class to make easier resolve controller methods
819a7f8 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Some updates:
5533249 
- [x] Validates all request thru request object,
- [x] Validation rules defined on model class,
- [x] Add new transaction method on Database class to handle transaction easily,
- [x] Some additional updates due to changes above

Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Fix validation issue
4450cf7 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Use httpclient directly to send mail instead of SparkPost client
5bb7684 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Fix sending mail via sparkpost 🎉
b7af819 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Remove sparkpost/sparkpost
9483be4 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Add phpunit for testing
7997383 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Copy link
Member Author

Mailer done thru Sparkpost.

image

Tinggal bershi-bersih yang lain.. 🎉 🎉 🥂

feryardiant added 4 commits May 4, 2017 07:36
@feryardiant
Patch user activation
c6e3bc9 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Add withRedirectRoute method
8ca9805 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Patch validation request
e68fee2 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant
Cleanup unused params
f1cef7d 
Signed-off-by: Fery Wardiyanto <[email protected]>
@feryardiant feryardiant mentioned this pull request Jun 6, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@okaprinarjaya okaprinarjaya okaprinarjaya approved these changes

@peterjkambey peterjkambey Awaiting requested review from peterjkambey

Assignees

@feryardiant feryardiant

Labels
discussion enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feryardiant @okaprinarjaya @herloct