Minor updates #27
Merged
Minor updates #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
2 tasks
Signed-off-by: Matt Friedman <[email protected]>
This reverts commit c1abae3.
Signed-off-by: Matt Friedman <[email protected]>
Crizz0
reviewed
Jan 20, 2024
| @@ -155,7 +155,11 @@ public function add_prefix() | |||
|
|
|||
| $tag = $this->request->variable('prefix_tag', '', true); | |||
| $prefix = $this->manager->add_prefix($tag, $this->forum_id); | |||
| $this->log($prefix['prefix_tag'], 'ACP_LOG_PREFIX_ADDED'); | |||
|
|
|||
| if ($prefix) | |||
There was a problem hiding this comment.
Does it not give feedback to the user, if this fails?
|
No. But feed back is not necessary. Submitting only does 1 things, adds the prefix to the list. If you're leaving it empty and hitting submit nothing is added to the list. It's so obvious that there's no need for feedback. The real problem is if it is blank now, you get a fatal error. This fixes that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.