Create a IsA expression #396
Conversation
src/Expression/ForClasses/IsA.php
Outdated
| \is_a($theClass->getFQCN(), $allowedFqcn, true) | ||
| || \is_subclass_of($theClass->getFQCN(), $allowedFqcn) |
There was a problem hiding this comment.
Do we really need to check both? Both do the same, except that is_a() also returns true for the class itself (like is_a(A::class, A::class)), AFAIK, so is_subclass_of() should never be called.
There was a problem hiding this comment.
unfortunately, is_a doesnt check for interface implementation, and is_subclass_of doesnt check for same class. :(
There was a problem hiding this comment.
unfortunately,
is_adoesn't check for interface implementation
I think it does: https://3v4l.org/91Yt8
AFAIK, is_a does the same as instanceof (and it is even more powerful, since it can check string class names and not only instances, if the third parameter is true).
There was a problem hiding this comment.
HAH! u r correct, I will fix this
There was a problem hiding this comment.
fixed and force pushed
hgraca
force-pushed
the
feat/isa_expression
branch
from
7b00915
to
5143cff
Compare
This will allow for testing if a class extends or implements another code unit, anywhere in the inheritance tree.
hgraca
force-pushed
the
feat/isa_expression
branch
from
5143cff
to
cafad1a
Compare
This will allow for testing if a class extends or
implements another code unit, anywhere in the inheritance tree.