Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change asymmetric visibility example to show how it simplifies code #1135

Merged
merged 1 commit into from
Nov 21, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions releases/8.4/release.inc
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,20 @@ PHP
<<<'PHP'
class PhpVersion
{
public string $version = '8.3';
}
private string $version = '8.3';

$phpVersion = new PhpVersion();
var_dump($phpVersion->version); // string(3) "8.3"
$phpVersion->version = 'PHP 8.4'; // No error
public function getVersion(): string
{
return $this->version;
}

public function increment(): void
{
[$major, $minor] = explode('.', $this->version);
$minor++;
$this->version = "$major.$minor";
}
}
PHP

); ?>
Expand All @@ -178,11 +186,14 @@ PHP
class PhpVersion
{
public private(set) string $version = '8.4';
}

$phpVersion = new PhpVersion();
var_dump($phpVersion->version); // string(3) "8.4"
$phpVersion->version = 'PHP 8.3'; // Visibility error
public function increment(): void
{
[$major, $minor] = explode('.', $this->version);
$minor++;
$this->version = "$major.$minor";
}
}
PHP
); ?>
</div>
Expand Down
Loading