Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of perceptual metrics #291

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Refactoring of perceptual metrics #291

wants to merge 8 commits into from

Conversation

zakajd
Copy link
Collaborator

@zakajd zakajd commented Feb 6, 2022 •
edited
Loading

Closes #261

Proposed Changes

  • Move LPIPS and DISTS into separate files
  • Mover test for LPIPS and DISTS into separate files
  • Do not inherit LPIPS and DISTS from StyleLoss class and re-implement all required (and simplified!) logic inside them
  • Add enable_grad flag to enable or disable gradients computation. Useful when using them as metrics, not loss functions.
  • Add tests to compare with reference implementations.
  • Validate why results of our LPIPS and original one differ
  • Validate failing test in DISTS

@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Apr 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Semantic discrepancy between DISTS and ContentLoss parameters
2 participants
@zakajd @bonlime