My greatest concern has to do with the reordering of the comment lines… #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with code. I made the changes because they felt most natural, that is, they feel more like what I see in the REPL. As I only hope to help, ignore that which doesn't.
|
I don't know what Travis is complaining about. I clicked "Details" and got a blank screen. What did I break? Is it running Make? If so, it works for me. Let me know if I need to fix something. |
|
I broke it. Don't worry, will fix. |
|
I'm pretty sure I changed a syntax quote to a simple quote somewhere when I shouldn't have. I went back to try to find it but couldn't. If I do, I'll send another PR. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the changes because they felt most natural, that is, they feel more like what I see in the REPL. As I only hope to help, ignore that which doesn't.
Thanks for the tutorial. It really helps.