Adds missing handling of DataUnionOf in RDF and OWX readers. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filippodebortoli
changed the title
|
Oh, I wasn't expecting you to fix that! I've done (the same) fix on another branch, but it was just to remind me. Happy for your to merge this. I agree about the tests; they are not comprehensively in testing the right thing. I think we could do with a few more files like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #69.
The related tests in
io::owx::readercould be improved, the reason the mishandling could not be detected is that the testio::owx::reader::test::datatype_union()only checks that one type definition appears in the ontology, no matter what its kind is. The testio::rdf::reader::test::datatype_union()seems also not to be informative, as it would in this case just compare the two faulty files.The writers seemed to already handle this construct properly.