Feature/generic return owx reader #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the OWX reader could only return a SetOntology<Rc<str>>, which meant it must be transfered to what ever Ontology type was needed if this was not right. Now it can return any type of MutableOntology.
RDFOntology is now a trait. The old RDFOntology struct is now called ConcreteRDFOntology. Quite a few trait implementations, particularly Default have been added.
Also add bench compile to pre-commit-config
filippodebortoli
approved these changes
Jul 3, 2024
filippodebortoli
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to merge this to address the issues raised here.
#113
Please let me know if there are any objections.