Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP3: Enable fingerprint sensor #692

Open
wants to merge 1 commit into
base: pie
Choose a base branch
from

Conversation

danielzhang130
Copy link
Contributor

No description provided.

@phhusson
Copy link
Owner

It's already enabled on all devices

@danielzhang130
Copy link
Contributor Author

@phhusson Thanks for the review. I don't believe it's enabled on FP3. There is no fingerprint option in settings. This patch defines the available sensors.

I also have a pixel 3 which sets this value via an overlay in the vendor directory, so I believe without that, fingerprint wouldn't work on pixel 3 neither. FP3 doesn't have that overlay in vendor, so it doesn't have fingerprint working.

I'm building on trebledroid 13 btw, would stuff be different somehow?

@phhusson
Copy link
Owner

Which TrebleDroid 13? On which android vendor version? At some points Android vendors <= 10 were missing fingerprint but that was fixed in TrebleDroid/platform_frameworks_base@15a193c

@danielzhang130
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants