-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better all-round 3D support #53
base: master
Are you sure you want to change the base?
Conversation
To Do:
|
i think distance and length is trivial and intersect and other a little bit harder ... postgis has a separate some 3D function (like distance3D) i don't know how is work in GEOS, but it may be more "backward compatible" to separate 3d function |
I think it's definitely a good idea to separate out the 3D stuff into different functions. I checked with GEOS people on IRC, looks like it only support 2D. |
The start of the PHP-native distance calculations are in place. "distance is trivial" my ass! :-P I'm still running into some problems with divide-by-zero errors that I need to investigate. |
Now that I've properly implemented distance in 2D, I'm beginning to realize how out of my league I am for implementing the same in 3D. Problems for 3D distance:
|
Hi @mkdgs, I definitely appreciate where your coming from. The problem is that if we were to implement it this way and removing all these non-universal methods from the parent classes will involve a lot of code duplication in child classes. I wish there was a way you could have a child-class "undeclare" a method. I wonder if there is a way we can both be happy by using traits instead of direct inheritance? In either case, can we not deal with these issues in this pull-request? Let's keep to the existing pattern (with all it warts) for the 3D stuff, and deal with how we do method inheritance in a separate issue? |
thanks @phayes, it may be for the future of geoPHP. for now just i have only moved the methods of Point. take a look into Simple Feature Access at http://www.opengeospatial.org/standards/sfa |
I'll check that out @mkdgs . Thanks for the link. |
I've started testing this and I'm running into all sorts of errors when I run the tests.
I'm going to try to correct these errors. |
hello phayes, |
No description provided.