Fix npm run new
#909
Merged
Fix npm run new
#909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illepic
commented
Jul 24, 2020
| path.extname = ext; | ||
| // Remove extension ('.twig') from basename, replace 'pattern" with name | ||
| path.basename = path.basename.replace(ext, '').replace('pattern', name); | ||
| // basename is ie '_patterns.twig' here |
There was a problem hiding this comment.
All the stuff above here was a duct tape fix due to a quirk in Yeoman. Looks like Yeoman fixed the quirk.
jryanconklin
approved these changes
Jul 24, 2020
FrederickEngelhardt
approved these changes
Jul 24, 2020
|
Possibly unrelated, we've had issues when yoeman is installed globally... The end result being that a new component is created in the directory/project where the theme was last installed. Does this fix that or is that a whole new issue? |
|
@adamjuran this file should indicate to Yeoman the "root" from which to run. |
madhaze
added a commit
that referenced
this pull request
Jul 24, 2020
* master: Fix `npm run new` (#909) feature: revise layout and add bottom spacer option (#903) issue-906: phpcs validation. (#907) bug: update particle namespace and update details class (#900) Remove reference to composer.json in editorconfig (#881) Update dependency yeoman-generator to ^4.11.0 (#866) July 02, 2020 npm dependencies (#882) task: update js config for forms (#880) Feature :: Add Tailwind Custom Forms Plugin + Drupal Templates (#859) PHP deprecated warning: Swapping parameters order in implode() function. (#858) NPM update to fix eslint regression (#865) Update dependency eslint to ^7.3.0 (#855) Update dependency terser-webpack-plugin to ^3.0.6 (#853) Update dependency webpack-cli to ^3.3.12 (#852) Update dependency stylelint to ^13.6.1 (#850) Update dependency eslint-import-resolver-webpack to ^0.12.2 (#846) Update Font Awesome (#854) NPM updates (#843) Prettier now runs against twig, update files with new linting (#839) # Conflicts: # apps/pl-default/pattern-lab/_patterns/01-atoms-demo/image/images.twig # source/default/_patterns/01-atoms/image/_image--bg.twig # source/default/_patterns/01-atoms/image/_image--picture.twig # source/default/_patterns/01-atoms/image/_image.twig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes Issue #905
Issue Description
npm run newwas failing to write out files with proper extensions. Also updates deps.Summary of Changes
Yeoman released a fix to internal file writing mechanisms that invalidated a stopgap measure we had in place.