Merge pull request #82 from astares/pharo_issue_16387

Using GitHub Tokens stopped working in P12 when loading non-public project
pharo-vcs · Apr 2, 2024 · e24b64b · e24b64b
2 parents 646d0d0 + a43e2d9
commit e24b64b
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/LibGit-Core.package/LGitCredentialsPlaintext.class/instance/createWith.urlUsername..st b/LibGit-Core.package/LGitCredentialsPlaintext.class/instance/createWith.urlUsername..st
@@ -1,11 +1,9 @@
 operations
 createWith: aStructure urlUsername: urlUsername
-
-	<todo: 'use exceptions instead of assertions'>
 	"I ignore the username that come from the url, as we are using plaintext credentials"
 
 	(self username isEmptyOrNil 
-		or: [ self passphrase isEmptyOrNil not ])
+		or: [ self passphrase isEmptyOrNil ])
 		ifTrue: [ LGitNoCredentialsProvided signal ].
 
 	self withReturnHandlerDo: [