Tag some ExternalAddress method as to ignore by testNoEquivalentSuperclassMethods #17416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…classMethods ExternalAddress reimplement multiple methods from it superclass to do the same and have some speed ups. Here I'm adding a pragma so that we declare them as false positive in testNoEquivalentSuperclassMethods with the goal of reducing little by little the number of violations of this test
MarcusDenker
approved these changes
Nov 19, 2024
jecisc
added
the
Status: Need more work
|
Good we should call that monomorphising the call sites :) |
|
ReleaseTest.testNoEquivalentSuperclassMethods |
jecisc
removed
the
Status: Need more work
|
Build did not pass and I wonder if this is not one of integration of hernan PR I did yesterday. This UI is super confusing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExternalAddress reimplement multiple methods from it superclass to do the same and have some speed ups. Here I'm adding a pragma so that we declare them as false positive in testNoEquivalentSuperclassMethods with the goal of reducing little by little the number of violations of this test