Avoid analyzing classes in Manifest methods while checking ReClassesHaveNoReferencesCondition #16954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add isManifest method for RB classes. Add testIsManifest. Fix failing #testTransform method in RBRemoveProtocolTransformationTest
…ManifestNamesAccordingToPackageNames fails
hernanmd
changed the title
hernanmd
changed the title
…t_from_classref_rule
balsa-sarenac
approved these changes
Jul 29, 2024
Ducasse
reviewed
Jul 30, 2024
…t_from_classref_rule
Check that superclass is not nil, as suggested by @Ducasse. Add tests
jecisc
approved these changes
Jul 31, 2024
hernanmd
deleted the
fix_exclude_package_manifest_from_classref_rule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes problems described in #16953.
Update the
violatorsmethod in ReClassesHaveNoReferencesCondition.Add isManifest method for RB classes.
Add testIsManifest.
Fix failing #testTransform method in RBRemoveProtocolTransformationTest